diff options
| author | xuatz <xzlow10@gmail.com> | 2025-05-18 01:51:46 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-05-17 17:51:46 +0100 |
| commit | f338f7b102e538889e4f16fac407f4d5f17fdf69 (patch) | |
| tree | f58bc5bfe956be851d7991414b677f6791b14bb3 | |
| parent | 4ae5857a40abb66a4cd79d2a07079ad9cef5d01b (diff) | |
| download | karakeep-f338f7b102e538889e4f16fac407f4d5f17fdf69.tar.zst | |
fix(api): make PUT bookmark to a list idempotent (#1427)
* fix(api): make duplicate PUT /lists/:id/bookmarks/:id as allowed operation
* apply pr comments
| -rw-r--r-- | packages/open-api/karakeep-openapi-spec.json | 22 | ||||
| -rw-r--r-- | packages/open-api/lib/lists.ts | 8 | ||||
| -rw-r--r-- | packages/trpc/models/lists.ts | 6 |
3 files changed, 2 insertions, 34 deletions
diff --git a/packages/open-api/karakeep-openapi-spec.json b/packages/open-api/karakeep-openapi-spec.json index 0f8074d4..3bdaed54 100644 --- a/packages/open-api/karakeep-openapi-spec.json +++ b/packages/open-api/karakeep-openapi-spec.json @@ -2071,28 +2071,6 @@ "204": { "description": "No content - the bookmark was added" }, - "400": { - "description": "Bookmark already in list", - "content": { - "application/json": { - "schema": { - "type": "object", - "properties": { - "code": { - "type": "string" - }, - "message": { - "type": "string" - } - }, - "required": [ - "code", - "message" - ] - } - } - } - }, "404": { "description": "List or bookmark not found", "content": { diff --git a/packages/open-api/lib/lists.ts b/packages/open-api/lib/lists.ts index 2273d33b..ab07e425 100644 --- a/packages/open-api/lib/lists.ts +++ b/packages/open-api/lib/lists.ts @@ -232,14 +232,6 @@ registry.registerPath({ 204: { description: "No content - the bookmark was added", }, - 400: { - description: "Bookmark already in list", - content: { - "application/json": { - schema: ErrorSchema, - }, - }, - }, 404: { description: "List or bookmark not found", content: { diff --git a/packages/trpc/models/lists.ts b/packages/trpc/models/lists.ts index 4da127d2..21b23593 100644 --- a/packages/trpc/models/lists.ts +++ b/packages/trpc/models/lists.ts @@ -260,10 +260,8 @@ export class ManualList extends List { } catch (e) { if (e instanceof SqliteError) { if (e.code == "SQLITE_CONSTRAINT_PRIMARYKEY") { - throw new TRPCError({ - code: "BAD_REQUEST", - message: `Bookmark ${bookmarkId} is already in the list ${this.list.id}`, - }); + // this is fine, it just means the bookmark is already in the list + return; } } throw new TRPCError({ |