diff options
| author | Simon Kenny <digithree@users.noreply.github.com> | 2025-06-07 21:57:48 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-06-07 21:57:48 +0100 |
| commit | ec31a971f6c2e3e058debf05fe8235c1d599b055 (patch) | |
| tree | cfd1b75c1581ce45592238d622e810ce7e7bbad6 /apps/mobile/app/dashboard/bookmarks | |
| parent | 09e5dd659d2b42e81692cfa092ca79dfa42fd485 (diff) | |
| download | karakeep-ec31a971f6c2e3e058debf05fe8235c1d599b055.tar.zst | |
feat(mobile): add reader/screenshot/archive view to bookmark preview (#1509)
* feat(mobile): add reader view by default to bookmark detail view, retaining WebView fallback
* feat(mobile): add dark mode support for mobile reader view
* Add selectors for different views for bookmark link
---------
Co-authored-by: MohamedBassem <me@mbassem.com>
Diffstat (limited to 'apps/mobile/app/dashboard/bookmarks')
| -rw-r--r-- | apps/mobile/app/dashboard/bookmarks/[slug]/index.tsx | 117 |
1 files changed, 105 insertions, 12 deletions
diff --git a/apps/mobile/app/dashboard/bookmarks/[slug]/index.tsx b/apps/mobile/app/dashboard/bookmarks/[slug]/index.tsx index 7edbd0b8..01ee61de 100644 --- a/apps/mobile/app/dashboard/bookmarks/[slug]/index.tsx +++ b/apps/mobile/app/dashboard/bookmarks/[slug]/index.tsx @@ -8,9 +8,15 @@ import { View, } from "react-native"; import ImageView from "react-native-image-viewing"; -import WebView from "react-native-webview"; +import * as Haptics from "expo-haptics"; import { Stack, useLocalSearchParams, useRouter } from "expo-router"; import BookmarkAssetImage from "@/components/bookmarks/BookmarkAssetImage"; +import { + BookmarkLinkArchivePreview, + BookmarkLinkBrowserPreview, + BookmarkLinkReaderPreview, + BookmarkLinkScreenshotPreview, +} from "@/components/bookmarks/BookmarkLinkPreview"; import BookmarkTextMarkdown from "@/components/bookmarks/BookmarkTextMarkdown"; import FullPageError from "@/components/FullPageError"; import { TailwindResolver } from "@/components/TailwindResolver"; @@ -21,7 +27,16 @@ import { Input } from "@/components/ui/Input"; import { useToast } from "@/components/ui/Toast"; import { useAssetUrl } from "@/lib/hooks"; import { api } from "@/lib/trpc"; -import { ClipboardList, Globe, Info, Tag, Trash2 } from "lucide-react-native"; +import { MenuView } from "@react-native-menu/menu"; +import { + ChevronDown, + ClipboardList, + Globe, + Info, + Tag, + Trash2, +} from "lucide-react-native"; +import { useColorScheme } from "nativewind"; import { useDeleteBookmark, @@ -29,6 +44,50 @@ import { } from "@karakeep/shared-react/hooks/bookmarks"; import { BookmarkTypes, ZBookmark } from "@karakeep/shared/types/bookmarks"; +type BookmarkLinkType = "browser" | "reader" | "screenshot" | "archive"; + +function BookmarkLinkTypeSelector({ + type, + onChange, +}: { + type: BookmarkLinkType; + onChange: (type: BookmarkLinkType) => void; +}) { + return ( + <MenuView + onPressAction={({ nativeEvent }) => { + Haptics.selectionAsync(); + onChange(nativeEvent.event as BookmarkLinkType); + }} + actions={[ + { + id: "reader", + title: "Reader", + state: type === "reader" ? "on" : undefined, + }, + { + id: "browser", + title: "Browser", + state: type === "browser" ? "on" : undefined, + }, + { + id: "screenshot", + title: "Screenshot", + state: type === "screenshot" ? "on" : undefined, + }, + { + id: "archive", + title: "Archive", + state: type === "archive" ? "on" : undefined, + }, + ]} + shouldOpenOnLongPress={false} + > + <ChevronDown onPress={() => Haptics.selectionAsync()} color="gray" /> + </MenuView> + ); +} + function BottomActions({ bookmark }: { bookmark: ZBookmark }) { const { toast } = useToast(); const router = useRouter(); @@ -151,17 +210,27 @@ function BottomActions({ bookmark }: { bookmark: ZBookmark }) { ); } -function BookmarkLinkView({ bookmark }: { bookmark: ZBookmark }) { +function BookmarkLinkView({ + bookmark, + bookmarkPreviewType, +}: { + bookmark: ZBookmark; + bookmarkPreviewType: BookmarkLinkType; +}) { if (bookmark.content.type !== BookmarkTypes.LINK) { throw new Error("Wrong content type rendered"); } - return ( - <WebView - startInLoadingState={true} - mediaPlaybackRequiresUserAction={true} - source={{ uri: bookmark.content.url }} - /> - ); + + switch (bookmarkPreviewType) { + case "browser": + return <BookmarkLinkBrowserPreview bookmark={bookmark} />; + case "reader": + return <BookmarkLinkReaderPreview bookmark={bookmark} />; + case "screenshot": + return <BookmarkLinkScreenshotPreview bookmark={bookmark} />; + case "archive": + return <BookmarkLinkArchivePreview bookmark={bookmark} />; + } } function BookmarkTextView({ bookmark }: { bookmark: ZBookmark }) { @@ -257,6 +326,11 @@ function BookmarkAssetView({ bookmark }: { bookmark: ZBookmark }) { export default function ListView() { const { slug } = useLocalSearchParams(); + const { colorScheme } = useColorScheme(); + + const [bookmarkLinkType, setBookmarkLinkType] = + useState<BookmarkLinkType>("reader"); + if (typeof slug !== "string") { throw new Error("Unexpected param type"); } @@ -265,7 +339,10 @@ export default function ListView() { data: bookmark, error, refetch, - } = api.bookmarks.getBookmark.useQuery({ bookmarkId: slug }); + } = api.bookmarks.getBookmark.useQuery({ + bookmarkId: slug, + includeContent: false, + }); if (error) { return <FullPageError error={error.message} onRetry={refetch} />; @@ -280,7 +357,12 @@ export default function ListView() { switch (bookmark.content.type) { case BookmarkTypes.LINK: title = bookmark.title ?? bookmark.content.title; - comp = <BookmarkLinkView bookmark={bookmark} />; + comp = ( + <BookmarkLinkView + bookmark={bookmark} + bookmarkPreviewType={bookmarkLinkType} + /> + ); break; case BookmarkTypes.TEXT: title = bookmark.title; @@ -298,6 +380,17 @@ export default function ListView() { headerTitle: title ?? "", headerBackTitle: "Back", headerTransparent: false, + headerTintColor: colorScheme === "dark" ? "#ffffff" : undefined, + headerStyle: { + backgroundColor: colorScheme === "dark" ? "#000000" : undefined, + }, + headerRight: () => + bookmark.content.type === BookmarkTypes.LINK ? ( + <BookmarkLinkTypeSelector + type={bookmarkLinkType} + onChange={(type) => setBookmarkLinkType(type)} + /> + ) : undefined, }} /> <View className="flex h-full"> |
