fix(tags): normalise leading hashes in tag names (#1317) (#1351)

* fix(tags): normalise leading hashes in tag names (#1317)

* move the transformation to zod

* fix openapi spec

---------

Co-authored-by: Mohamed Bassem <me@mbassem.com>

1 files changed, 6 insertions, 3 deletions

diff --git a/packages/trpc/routers/bookmarks.ts b/packages/trpc/routers/bookmarks.ts
index 815cf90d..2a02a0cd 100644
--- a/packages/trpc/routers/bookmarks.ts
+++ b/packages/trpc/routers/bookmarks.ts
@@ -50,6 +50,7 @@ import {
   zSearchBookmarksRequestSchema,
   zUpdateBookmarksRequestSchema,
 } from "@karakeep/shared/types/bookmarks";
+import { normalizeTagName } from "@karakeep/shared/utils/tag";
 
 import type { AuthedContext, Context } from "../index";
 import { authedProcedure, router } from "../index";
@@ -867,9 +868,11 @@ export const bookmarksAppRouter = router({
           };
         }
 
-        const toAddTagNames = input.attach.flatMap((i) =>
-          i.tagName ? [i.tagName] : [],
-        );
+        const toAddTagNames = input.attach
+          .flatMap((i) => (i.tagName ? [i.tagName] : []))
+          .map(normalizeTagName) // strip leading #
+          .filter((n) => n.length > 0); // drop empty results
+
         const toAddTagIds = input.attach.flatMap((i) =>
           i.tagId ? [i.tagId] : [],
         );