diff options
| author | Benjamin Michaelis <github@relay.benjamin.michaelis.net> | 2025-10-25 11:12:08 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-10-25 19:12:08 +0100 |
| commit | 046c29dcf1083f0ab89b080f7696e6d642a6bd17 (patch) | |
| tree | 76ecd012080781c87ce53f045721adfabe88019b /packages | |
| parent | 8c0aae33b878827ca0978d9979bb4f2b51ef2f6e (diff) | |
| download | karakeep-046c29dcf1083f0ab89b080f7696e6d642a6bd17.tar.zst | |
fix: update OpenAI API to use max_completion_tokens instead of max_tokens (#2000)
* fix: update OpenAI API to use max_completion_tokens instead of max_tokens
The OpenAI API has deprecated max_tokens in favor of max_completion_tokens
for newer models. This change updates both text and image model calls.
* feat: add support for max_completion_tokens in OpenAI inference configuration
Diffstat (limited to 'packages')
| -rw-r--r-- | packages/shared/config.ts | 2 | ||||
| -rw-r--r-- | packages/shared/inference.ts | 8 |
2 files changed, 8 insertions, 2 deletions
diff --git a/packages/shared/config.ts b/packages/shared/config.ts index 5343246d..8e7d0252 100644 --- a/packages/shared/config.ts +++ b/packages/shared/config.ts @@ -65,6 +65,7 @@ const allEnv = z.object({ EMBEDDING_TEXT_MODEL: z.string().default("text-embedding-3-small"), INFERENCE_CONTEXT_LENGTH: z.coerce.number().default(2048), INFERENCE_MAX_OUTPUT_TOKENS: z.coerce.number().default(2048), + INFERENCE_USE_MAX_COMPLETION_TOKENS: stringBool("false"), INFERENCE_SUPPORTS_STRUCTURED_OUTPUT: optionalStringBool(), INFERENCE_OUTPUT_SCHEMA: z .enum(["structured", "json", "plain"]) @@ -241,6 +242,7 @@ const serverConfigSchema = allEnv.transform((val, ctx) => { inferredTagLang: val.INFERENCE_LANG, contextLength: val.INFERENCE_CONTEXT_LENGTH, maxOutputTokens: val.INFERENCE_MAX_OUTPUT_TOKENS, + useMaxCompletionTokens: val.INFERENCE_USE_MAX_COMPLETION_TOKENS, outputSchema: val.INFERENCE_SUPPORTS_STRUCTURED_OUTPUT !== undefined ? val.INFERENCE_SUPPORTS_STRUCTURED_OUTPUT diff --git a/packages/shared/inference.ts b/packages/shared/inference.ts index 41026fbd..7689f4f4 100644 --- a/packages/shared/inference.ts +++ b/packages/shared/inference.ts @@ -90,7 +90,9 @@ class OpenAIInferenceClient implements InferenceClient { { messages: [{ role: "user", content: prompt }], model: serverConfig.inference.textModel, - max_tokens: serverConfig.inference.maxOutputTokens, + ...(serverConfig.inference.useMaxCompletionTokens + ? { max_completion_tokens: serverConfig.inference.maxOutputTokens } + : { max_tokens: serverConfig.inference.maxOutputTokens }), response_format: mapInferenceOutputSchema( { structured: optsWithDefaults.schema @@ -127,7 +129,9 @@ class OpenAIInferenceClient implements InferenceClient { const chatCompletion = await this.openAI.chat.completions.create( { model: serverConfig.inference.imageModel, - max_tokens: serverConfig.inference.maxOutputTokens, + ...(serverConfig.inference.useMaxCompletionTokens + ? { max_completion_tokens: serverConfig.inference.maxOutputTokens } + : { max_tokens: serverConfig.inference.maxOutputTokens }), response_format: mapInferenceOutputSchema( { structured: optsWithDefaults.schema |