From 545cac1967f6882780021407a474690fea3f11ed Mon Sep 17 00:00:00 2001
From: Mohamed Bassem <me@mbassem.com>
Date: Tue, 1 Jul 2025 22:51:59 +0000
Subject: feat: Add per user bookmark count quota

---
 apps/web/components/admin/ChangeRoleDialog.tsx | 154 ---------------------
 apps/web/components/admin/UpdateUserDialog.tsx | 181 +++++++++++++++++++++++++
 apps/web/components/admin/UserList.tsx         |  16 ++-
 3 files changed, 193 insertions(+), 158 deletions(-)
 delete mode 100644 apps/web/components/admin/ChangeRoleDialog.tsx
 create mode 100644 apps/web/components/admin/UpdateUserDialog.tsx

(limited to 'apps/web/components/admin')

diff --git a/apps/web/components/admin/ChangeRoleDialog.tsx b/apps/web/components/admin/ChangeRoleDialog.tsx
deleted file mode 100644
index e2552a15..00000000
--- a/apps/web/components/admin/ChangeRoleDialog.tsx
+++ /dev/null
@@ -1,154 +0,0 @@
-import { useEffect, useState } from "react";
-import { ActionButton } from "@/components/ui/action-button";
-import { Button } from "@/components/ui/button";
-import {
-  Dialog,
-  DialogClose,
-  DialogContent,
-  DialogFooter,
-  DialogHeader,
-  DialogTitle,
-  DialogTrigger,
-} from "@/components/ui/dialog";
-import {
-  Form,
-  FormControl,
-  FormField,
-  FormItem,
-  FormLabel,
-  FormMessage,
-} from "@/components/ui/form";
-import {
-  Select,
-  SelectContent,
-  SelectItem,
-  SelectTrigger,
-  SelectValue,
-} from "@/components/ui/select";
-import { toast } from "@/components/ui/use-toast";
-import { api } from "@/lib/trpc";
-import { zodResolver } from "@hookform/resolvers/zod";
-import { TRPCClientError } from "@trpc/client";
-import { useForm } from "react-hook-form";
-import { z } from "zod";
-
-import { changeRoleSchema } from "@karakeep/shared/types/admin";
-
-type ChangeRoleSchema = z.infer<typeof changeRoleSchema>;
-
-interface ChangeRoleDialogProps {
-  userId: string;
-  currentRole: "user" | "admin";
-  children?: React.ReactNode;
-}
-
-export default function ChangeRoleDialog({
-  userId,
-  currentRole,
-  children,
-}: ChangeRoleDialogProps) {
-  const apiUtils = api.useUtils();
-  const [isOpen, onOpenChange] = useState(false);
-  const form = useForm<ChangeRoleSchema>({
-    resolver: zodResolver(changeRoleSchema),
-    defaultValues: {
-      userId,
-      role: currentRole,
-    },
-  });
-  const { mutate, isPending } = api.admin.changeRole.useMutation({
-    onSuccess: () => {
-      toast({
-        description: "Role changed successfully",
-      });
-      apiUtils.users.list.invalidate();
-      onOpenChange(false);
-    },
-    onError: (error) => {
-      if (error instanceof TRPCClientError) {
-        toast({
-          variant: "destructive",
-          description: error.message,
-        });
-      } else {
-        toast({
-          variant: "destructive",
-          description: "Failed to change role",
-        });
-      }
-    },
-  });
-
-  useEffect(() => {
-    if (isOpen) {
-      form.reset();
-    }
-  }, [isOpen, form]);
-
-  return (
-    <Dialog open={isOpen} onOpenChange={onOpenChange}>
-      <DialogTrigger asChild>{children}</DialogTrigger>
-      <DialogContent>
-        <DialogTrigger asChild></DialogTrigger>
-        <DialogHeader>
-          <DialogTitle>Change Role</DialogTitle>
-        </DialogHeader>
-        <Form {...form}>
-          <form onSubmit={form.handleSubmit((val) => mutate(val))}>
-            <div className="flex w-full flex-col space-y-2">
-              <FormField
-                control={form.control}
-                name="role"
-                render={({ field }) => (
-                  <FormItem>
-                    <FormLabel>Role</FormLabel>
-                    <FormControl>
-                      <Select
-                        onValueChange={field.onChange}
-                        defaultValue={field.value}
-                      >
-                        <SelectTrigger className="w-full">
-                          <SelectValue />
-                        </SelectTrigger>
-                        <SelectContent>
-                          <SelectItem value="user">User</SelectItem>
-                          <SelectItem value="admin">Admin</SelectItem>
-                        </SelectContent>
-                      </Select>
-                    </FormControl>
-                    <FormMessage />
-                  </FormItem>
-                )}
-              />
-              <FormField
-                control={form.control}
-                name="userId"
-                render={({ field }) => (
-                  <FormItem>
-                    <FormControl>
-                      <input type="hidden" {...field} />
-                    </FormControl>
-                  </FormItem>
-                )}
-              />
-              <DialogFooter className="sm:justify-end">
-                <DialogClose asChild>
-                  <Button type="button" variant="secondary">
-                    Close
-                  </Button>
-                </DialogClose>
-                <ActionButton
-                  type="submit"
-                  loading={isPending}
-                  disabled={isPending}
-                >
-                  Change
-                </ActionButton>
-              </DialogFooter>
-            </div>
-          </form>
-        </Form>
-      </DialogContent>
-    </Dialog>
-  );
-}
diff --git a/apps/web/components/admin/UpdateUserDialog.tsx b/apps/web/components/admin/UpdateUserDialog.tsx
new file mode 100644
index 00000000..82a239ca
--- /dev/null
+++ b/apps/web/components/admin/UpdateUserDialog.tsx
@@ -0,0 +1,181 @@
+import { useEffect, useState } from "react";
+import { ActionButton } from "@/components/ui/action-button";
+import { Button } from "@/components/ui/button";
+import {
+  Dialog,
+  DialogClose,
+  DialogContent,
+  DialogFooter,
+  DialogHeader,
+  DialogTitle,
+  DialogTrigger,
+} from "@/components/ui/dialog";
+import {
+  Form,
+  FormControl,
+  FormField,
+  FormItem,
+  FormLabel,
+  FormMessage,
+} from "@/components/ui/form";
+import { Input } from "@/components/ui/input";
+import {
+  Select,
+  SelectContent,
+  SelectItem,
+  SelectTrigger,
+  SelectValue,
+} from "@/components/ui/select";
+import { toast } from "@/components/ui/use-toast";
+import { api } from "@/lib/trpc";
+import { zodResolver } from "@hookform/resolvers/zod";
+import { TRPCClientError } from "@trpc/client";
+import { useForm } from "react-hook-form";
+import { z } from "zod";
+
+import { updateUserSchema } from "@karakeep/shared/types/admin";
+
+type UpdateUserSchema = z.infer<typeof updateUserSchema>;
+
+interface UpdateUserDialogProps {
+  userId: string;
+  currentRole: "user" | "admin";
+  currentQuota: number | null;
+  children?: React.ReactNode;
+}
+export default function UpdateUserDialog({
+  userId,
+  currentRole,
+  currentQuota,
+  children,
+}: UpdateUserDialogProps) {
+  const apiUtils = api.useUtils();
+  const [isOpen, onOpenChange] = useState(false);
+  const defaultValues = {
+    userId,
+    role: currentRole,
+    bookmarkQuota: currentQuota,
+  };
+  const form = useForm<UpdateUserSchema>({
+    resolver: zodResolver(updateUserSchema),
+    defaultValues,
+  });
+  const { mutate, isPending } = api.admin.updateUser.useMutation({
+    onSuccess: () => {
+      toast({
+        description: "User updated successfully",
+      });
+      apiUtils.users.list.invalidate();
+      onOpenChange(false);
+    },
+    onError: (error) => {
+      if (error instanceof TRPCClientError) {
+        toast({
+          variant: "destructive",
+          description: error.message,
+        });
+      } else {
+        toast({
+          variant: "destructive",
+          description: "Failed to update user",
+        });
+      }
+    },
+  });
+
+  useEffect(() => {
+    if (isOpen) {
+      form.reset(defaultValues);
+    }
+  }, [isOpen, form]);
+
+  return (
+    <Dialog open={isOpen} onOpenChange={onOpenChange}>
+      <DialogTrigger asChild>{children}</DialogTrigger>
+      <DialogContent>
+        <DialogTrigger asChild></DialogTrigger>
+        <DialogHeader>
+          <DialogTitle>Edit User</DialogTitle>
+        </DialogHeader>
+        <Form {...form}>
+          <form onSubmit={form.handleSubmit((val) => mutate(val))}>
+            <div className="flex w-full flex-col space-y-4">
+              <FormField
+                control={form.control}
+                name="role"
+                render={({ field }) => (
+                  <FormItem>
+                    <FormLabel>Role</FormLabel>
+                    <FormControl>
+                      <Select
+                        onValueChange={field.onChange}
+                        defaultValue={field.value}
+                      >
+                        <SelectTrigger className="w-full">
+                          <SelectValue />
+                        </SelectTrigger>
+                        <SelectContent>
+                          <SelectItem value="user">User</SelectItem>
+                          <SelectItem value="admin">Admin</SelectItem>
+                        </SelectContent>
+                      </Select>
+                    </FormControl>
+                    <FormMessage />
+                  </FormItem>
+                )}
+              />
+              <FormField
+                control={form.control}
+                name="bookmarkQuota"
+                render={({ field }) => (
+                  <FormItem>
+                    <FormLabel>Bookmark Quota</FormLabel>
+                    <FormControl>
+                      <Input
+                        type="number"
+                        min="0"
+                        placeholder="Unlimited (leave empty)"
+                        {...field}
+                        value={field.value ?? ""}
+                        onChange={(e) => {
+                          const value = e.target.value;
+                          field.onChange(value === "" ? null : parseInt(value));
+                        }}
+                      />
+                    </FormControl>
+                    <FormMessage />
+                  </FormItem>
+                )}
+              />
+              <FormField
+                control={form.control}
+                name="userId"
+                render={({ field }) => (
+                  <FormItem>
+                    <FormControl>
+                      <input type="hidden" {...field} />
+                    </FormControl>
+                  </FormItem>
+                )}
+              />
+              <DialogFooter className="sm:justify-end">
+                <DialogClose asChild>
+                  <Button type="button" variant="secondary">
+                    Close
+                  </Button>
+                </DialogClose>
+                <ActionButton
+                  type="submit"
+                  loading={isPending}
+                  disabled={isPending}
+                >
+                  Update
+                </ActionButton>
+              </DialogFooter>
+            </div>
+          </form>
+        </Form>
+      </DialogContent>
+    </Dialog>
+  );
+}
diff --git a/apps/web/components/admin/UserList.tsx b/apps/web/components/admin/UserList.tsx
index c32c13e3..a3b4d94f 100644
--- a/apps/web/components/admin/UserList.tsx
+++ b/apps/web/components/admin/UserList.tsx
@@ -19,8 +19,8 @@ import { useSession } from "next-auth/react";
 
 import ActionConfirmingDialog from "../ui/action-confirming-dialog";
 import AddUserDialog from "./AddUserDialog";
-import ChangeRoleDialog from "./ChangeRoleDialog";
 import ResetPasswordDialog from "./ResetPasswordDialog";
+import UpdateUserDialog from "./UpdateUserDialog";
 
 function toHumanReadableSize(size: number) {
   const sizes = ["Bytes", "KB", "MB", "GB", "TB"];
@@ -71,6 +71,7 @@ export default function UsersSection() {
           <TableHead>{t("common.name")}</TableHead>
           <TableHead>{t("common.email")}</TableHead>
           <TableHead>{t("admin.users_list.num_bookmarks")}</TableHead>
+          <TableHead>{t("common.quota")}</TableHead>
           <TableHead>{t("admin.users_list.asset_sizes")}</TableHead>
           <TableHead>{t("common.role")}</TableHead>
           <TableHead>{t("admin.users_list.local_user")}</TableHead>
@@ -84,6 +85,9 @@ export default function UsersSection() {
               <TableCell className="py-1">
                 {userStats[u.id].numBookmarks}
               </TableCell>
+              <TableCell className="py-1">
+                {u.bookmarkQuota ?? t("admin.users_list.unlimited")}
+              </TableCell>
               <TableCell className="py-1">
                 {toHumanReadableSize(userStats[u.id].assetSizes)}
               </TableCell>
@@ -132,15 +136,19 @@ export default function UsersSection() {
                     <KeyRound size={16} color="red" />
                   </ButtonWithTooltip>
                 </ResetPasswordDialog>
-                <ChangeRoleDialog userId={u.id} currentRole={u.role!}>
+                <UpdateUserDialog
+                  userId={u.id}
+                  currentRole={u.role!}
+                  currentQuota={u.bookmarkQuota}
+                >
                   <ButtonWithTooltip
-                    tooltip={t("admin.users_list.change_role")}
+                    tooltip="Edit User"
                     variant="outline"
                     disabled={session!.user.id == u.id}
                   >
                     <Pencil size={16} color="red" />
                   </ButtonWithTooltip>
-                </ChangeRoleDialog>
+                </UpdateUserDialog>
               </TableCell>
             </TableRow>
           ))}
-- 
cgit v1.2.3-70-g09d2