From 88c73e212c4510ce41ad8c6557fa7d5c8f72d199 Mon Sep 17 00:00:00 2001 From: Mohamed Bassem Date: Mon, 17 Nov 2025 01:12:41 +0000 Subject: feat: Add collaborative lists (#2146) * feat: Add collaborative lists backend implementation This commit implements the core backend functionality for collaborative lists, allowing multiple users to share and interact with bookmark lists. Database changes: - Add listCollaborators table to track users with access to lists and their roles (viewer/editor) - Add addedBy field to bookmarksInLists to track who added bookmarks - Add relations for collaborative list functionality Access control updates: - Update List model to support role-based access (owner/editor/viewer) - Add methods to check and enforce permissions for list operations - Update Bookmark model to allow access through collaborative lists - Modify bookmark queries to include bookmarks from collaborative lists List collaboration features: - Add/remove/update collaborators - Get list of collaborators - Get lists shared with current user - Only manual lists can have collaborators tRPC procedures: - addCollaborator: Add a user as a collaborator to a list - removeCollaborator: Remove a collaborator from a list - updateCollaboratorRole: Change a collaborator's role - getCollaborators: Get all collaborators for a list - getSharedWithMe: Get all lists shared with the current user - cloneBookmark: Clone a bookmark to the current user's collection Implementation notes: - Editors can add/remove bookmarks from the list (must own the bookmark) - Viewers can only view bookmarks in the list - Only the list owner can manage collaborators and list metadata - Smart lists cannot have collaborators (only manual lists) - Users cannot edit bookmarks they don't own, even in shared lists * feat: Add collaborative lists frontend UI This commit implements the frontend user interface for collaborative lists, allowing users to view shared bookmarks and manage list collaborators. New pages: - /dashboard/shared: Shows bookmarks from lists shared with the user - Displays bookmarks from all collaborative lists - Uses SharedBookmarks component - Shows empty state when no lists are shared Navigation: - Added "Shared with you" link to sidebar with Users icon - Positioned after "Home" in main navigation - Available in both desktop and mobile sidebar Collaborator management: - ManageCollaboratorsModal component for managing list collaborators - Add collaborators by user ID with viewer/editor role - View current collaborators with their roles - Update collaborator roles inline - Remove collaborators - Shows empty state when no collaborators - Integrated into ListOptions dropdown menu - Accessible via "Manage Collaborators" menu item Components created: - SharedBookmarks.tsx: Server component fetching shared lists/bookmarks - ManageCollaboratorsModal.tsx: Client component with tRPC mutations - /dashboard/shared/page.tsx: Route for shared bookmarks page UI features: - Role selector for viewer/editor permissions - Real-time collaborator list updates - Toast notifications for success/error states - Loading states for async operations - Responsive design matching existing UI patterns Implementation notes: - Uses existing tRPC endpoints (getSharedWithMe, getCollaborators, etc.) - Follows established modal patterns from ShareListModal - Integrates seamlessly with existing list UI - Currently uses user ID for adding collaborators (email lookup TBD) * fix typecheck * add collaborator by email * add shared list in the sidebar * fix perm issue * hide UI components from non list owners * list leaving * fix shared bookmarks showing up in homepage * fix getBookmark access check * e2e tests * hide user specific fields from shared lists * simplify bookmark perm checks * disable editable fields in bookmark preview * hide lists if they don't have options * fix list ownership * fix highlights * move tests to trpc * fix alignment of leave list * make tag lists unclickable * allow editors to remove from list * add a badge for shared lists * remove bookmarks of user when they're removed from a list * fix tests * show owner in the manage collab modal * fix hasCollab * drop shared with you * i18n * beta badge * correctly invalidate caches on collab change * reduce unnecessary changes * Add ratelimits * stop manually removing bookmarks on remove * some fixes * fixes * remove unused function * improve tests --------- Co-authored-by: Claude --- apps/web/lib/i18n/locales/en/translation.json | 32 +++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) (limited to 'apps/web/lib/i18n/locales') diff --git a/apps/web/lib/i18n/locales/en/translation.json b/apps/web/lib/i18n/locales/en/translation.json index 7f322a8a..5db867a2 100644 --- a/apps/web/lib/i18n/locales/en/translation.json +++ b/apps/web/lib/i18n/locales/en/translation.json @@ -470,6 +470,7 @@ "lists": { "all_lists": "All Lists", "favourites": "Favourites", + "shared": "Shared", "new_list": "New List", "edit_list": "Edit List", "share_list": "Share List", @@ -501,6 +502,37 @@ "title": "Public List", "description": "Allow others to view this list", "share_link": "Share Link" + }, + "collaborators": { + "manage": "Manage Collaborators", + "view": "View Collaborators", + "collaborators": "Collaborators", + "add": "Add Collaborator", + "current": "Current Collaborators", + "enter_email": "Enter email address", + "please_enter_email": "Please enter an email address", + "added_successfully": "Collaborator added successfully", + "failed_to_add": "Failed to add collaborator", + "removed": "Collaborator removed", + "failed_to_remove": "Failed to remove collaborator", + "role_updated": "Role updated", + "failed_to_update_role": "Failed to update role", + "viewer": "Viewer", + "editor": "Editor", + "owner": "Owner", + "viewer_description": "Can view bookmarks in the list", + "editor_description": "Can add and remove bookmarks", + "no_collaborators": "No collaborators yet. Add someone to start collaborating!", + "no_collaborators_readonly": "No collaborators for this list.", + "people_with_access": "People who have access to this list", + "add_or_remove": "Add or remove people who can access this list" + }, + "leave_list": { + "title": "Leave List", + "confirm_message": "Are you sure you want to leave {{icon}} {{name}}?", + "warning": "You will no longer be able to view or access bookmarks in this list. The list owner can add you back if needed.", + "action": "Leave List", + "success": "You have left \"{{icon}} {{name}}\"" } }, "tags": { -- cgit v1.2.3-70-g09d2