From f53ad0a1bf373e4064ff3e142bfce4b27e4ef9d5 Mon Sep 17 00:00:00 2001 From: Adrian-Ryan Acala Date: Sat, 7 Jun 2025 08:29:50 -0700 Subject: fix: preserve unsaved title changes when modifying bookmark tags in the edit dialog (#1515) * feat: preserve unsaved title changes when modifying bookmark tags Prevents loss of unsaved title edits when users interact with tag selectors or other UI elements. Adds useDialogFormReset hook to maintain form state consistency across component re-renders. Fixes #1339 * Revert unnecessary modifications --------- Co-authored-by: Mohamed Bassem --- apps/web/lib/hooks/useDialogFormReset.ts | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 apps/web/lib/hooks/useDialogFormReset.ts (limited to 'apps/web/lib') diff --git a/apps/web/lib/hooks/useDialogFormReset.ts b/apps/web/lib/hooks/useDialogFormReset.ts new file mode 100644 index 00000000..de087ca9 --- /dev/null +++ b/apps/web/lib/hooks/useDialogFormReset.ts @@ -0,0 +1,27 @@ +import type { FieldValues, UseFormReturn } from "react-hook-form"; +import { useEffect, useRef } from "react"; + +/** + * Custom hook to handle form reset behavior in dialogs + * Only resets the form when the dialog transitions from closed to open, + * preventing loss of unsaved changes when external data updates occur + * + * @param open - Dialog open state + * @param form - React Hook Form instance + * @param resetData - Data to reset the form with + */ +export function useDialogFormReset( + open: boolean, + form: UseFormReturn, + resetData: T, +) { + const prevOpenRef = useRef(open); + + useEffect(() => { + // Only reset form when transitioning from closed to open, not on data updates + if (open && !prevOpenRef.current) { + form.reset(resetData); + } + prevOpenRef.current = open; + }, [open, form, resetData]); +} -- cgit v1.2.3-70-g09d2