From 5f0934acc0f7dde119be9f0a42a42742ec128377 Mon Sep 17 00:00:00 2001
From: Mohamed Bassem <me@mbassem.com>
Date: Sun, 23 Nov 2025 00:54:38 +0000
Subject: feat: Add invitation approval for shared lists (#2152)

* feat: Add invitation approval system for collaborative lists

- Add database schema changes to support pending invitations
  - Add status field (pending/accepted/declined) to listCollaborators
  - Add invitedAt and invitedEmail fields for tracking
  - Add index on status for efficient queries

- Update List model with invitation workflow methods
  - Modify addCollaboratorByEmail to create pending invitations
  - Add acceptInvitation() for users to accept invites
  - Add declineInvitation() for users to decline invites
  - Add revokeInvitation() for owners to revoke pending invites
  - Add getPendingInvitations() to get user's pending invites

- Implement privacy protection for pending invitations
  - Mask user names as "Pending User" until invitation is accepted
  - Only show email to list owner for pending invitations

- Update getSharedWithUser to only include accepted collaborations
  - Ensures lists only appear after invitation is accepted

* feat: Add tRPC procedures and email notifications for list invitations

- Add new tRPC procedures for invitation workflow
  - acceptInvitation: Allow users to accept pending invitations
  - declineInvitation: Allow users to decline invitations
  - revokeInvitation: Allow owners to revoke pending invitations
  - getPendingInvitations: Get all pending invitations for current user

- Update getCollaborators output schema
  - Add status, invitedAt fields to collaborator objects
  - Support privacy-masked user info for pending invitations

- Add sendListInvitationEmail function
  - Email notification when user is invited to collaborate
  - Includes list name, inviter name, and link to view invitation
  - Gracefully handles missing SMTP configuration

- Integrate email sending into invitation workflow
  - Send email when new invitation is created
  - Send email when declined invitation is renewed
  - Catch and log errors without failing the invitation

* feat: Add UI for list invitation approval workflow

- Update ManageCollaboratorsModal to support pending invitations
  - Show "Pending" badge for pending invitations
  - Add revoke button for owners to cancel pending invitations
  - Update success message to reflect invitation sent
  - Disable role change and remove buttons for pending invitations

- Create PendingInvitationsCard component
  - Display all pending invitations for the current user
  - Show list name, description, inviter, and role
  - Provide Accept and Decline buttons
  - Auto-hide when no pending invitations exist

- Add PendingInvitationsCard to lists page
  - Show at the top of the lists page
  - Only renders when user has pending invitations

* fix: Add missing translation keys and fix TypeScript errors

- Add translation keys for invitation system
  - lists.collaborators.invitation_sent
  - lists.collaborators.pending
  - lists.collaborators.revoke
  - lists.collaborators.invitation_revoked
  - lists.collaborators.failed_to_revoke
  - lists.invitations.* (all invitation-related keys)

- Fix TypeScript errors in email sending
  - Handle optional user.name with fallback to 'A user'

* wip

* fixes

* more fixes

* fix revoke

* more improvements

* comment fix

* fix email url

* fix schemas

* split pending invites into components

* more fixes

* test

* test fixes

---------

Co-authored-by: Claude <noreply@anthropic.com>
---
 apps/web/app/dashboard/lists/page.tsx              |  12 +-
 .../dashboard/lists/ManageCollaboratorsModal.tsx   |  51 ++++++-
 .../dashboard/lists/PendingInvitationsCard.tsx     | 158 +++++++++++++++++++++
 apps/web/lib/i18n/locales/en/translation.json      |  17 +++
 4 files changed, 231 insertions(+), 7 deletions(-)
 create mode 100644 apps/web/components/dashboard/lists/PendingInvitationsCard.tsx

(limited to 'apps/web')

diff --git a/apps/web/app/dashboard/lists/page.tsx b/apps/web/app/dashboard/lists/page.tsx
index 1c28073d..7950cd76 100644
--- a/apps/web/app/dashboard/lists/page.tsx
+++ b/apps/web/app/dashboard/lists/page.tsx
@@ -1,4 +1,5 @@
 import AllListsView from "@/components/dashboard/lists/AllListsView";
+import { PendingInvitationsCard } from "@/components/dashboard/lists/PendingInvitationsCard";
 import { Separator } from "@/components/ui/separator";
 import { useTranslation } from "@/lib/i18n/server";
 import { api } from "@/server/api/client";
@@ -9,10 +10,13 @@ export default async function ListsPage() {
   const lists = await api.lists.list();
 
   return (
-    <div className="flex flex-col gap-3 rounded-md border bg-background p-4">
-      <p className="text-2xl">📋 {t("lists.all_lists")}</p>
-      <Separator />
-      <AllListsView initialData={lists.lists} />
+    <div className="flex flex-col gap-4">
+      <PendingInvitationsCard />
+      <div className="flex flex-col gap-3 rounded-md border bg-background p-4">
+        <p className="text-2xl">📋 {t("lists.all_lists")}</p>
+        <Separator />
+        <AllListsView initialData={lists.lists} />
+      </div>
     </div>
   );
 }
diff --git a/apps/web/components/dashboard/lists/ManageCollaboratorsModal.tsx b/apps/web/components/dashboard/lists/ManageCollaboratorsModal.tsx
index 8e0a0602..232a944b 100644
--- a/apps/web/components/dashboard/lists/ManageCollaboratorsModal.tsx
+++ b/apps/web/components/dashboard/lists/ManageCollaboratorsModal.tsx
@@ -78,7 +78,7 @@ export function ManageCollaboratorsModal({
   const addCollaborator = api.lists.addCollaborator.useMutation({
     onSuccess: async () => {
       toast({
-        description: t("lists.collaborators.added_successfully"),
+        description: t("lists.collaborators.invitation_sent"),
       });
       setNewCollaboratorEmail("");
       await invalidateListCaches();
@@ -122,6 +122,21 @@ export function ManageCollaboratorsModal({
     },
   });
 
+  const revokeInvitation = api.lists.revokeInvitation.useMutation({
+    onSuccess: async () => {
+      toast({
+        description: t("lists.collaborators.invitation_revoked"),
+      });
+      await invalidateListCaches();
+    },
+    onError: (error) => {
+      toast({
+        variant: "destructive",
+        description: error.message || t("lists.collaborators.failed_to_revoke"),
+      });
+    },
+  });
+
   const handleAddCollaborator = () => {
     if (!newCollaboratorEmail.trim()) {
       toast({
@@ -262,8 +277,20 @@ export function ManageCollaboratorsModal({
                       className="flex items-center justify-between rounded-lg border p-3"
                     >
                       <div className="flex-1">
-                        <div className="font-medium">
-                          {collaborator.user.name}
+                        <div className="flex items-center gap-2">
+                          <div className="font-medium">
+                            {collaborator.user.name}
+                          </div>
+                          {collaborator.status === "pending" && (
+                            <Badge variant="outline" className="text-xs">
+                              {t("lists.collaborators.pending")}
+                            </Badge>
+                          )}
+                          {collaborator.status === "declined" && (
+                            <Badge variant="destructive" className="text-xs">
+                              {t("lists.collaborators.declined")}
+                            </Badge>
+                          )}
                         </div>
                         <div className="text-sm text-muted-foreground">
                           {collaborator.user.email}
@@ -273,6 +300,24 @@ export function ManageCollaboratorsModal({
                         <div className="text-sm capitalize text-muted-foreground">
                           {collaborator.role}
                         </div>
+                      ) : collaborator.status !== "accepted" ? (
+                        <div className="flex items-center gap-2">
+                          <div className="text-sm capitalize text-muted-foreground">
+                            {collaborator.role}
+                          </div>
+                          <Button
+                            variant="ghost"
+                            size="sm"
+                            onClick={() =>
+                              revokeInvitation.mutate({
+                                invitationId: collaborator.id,
+                              })
+                            }
+                            disabled={revokeInvitation.isPending}
+                          >
+                            {t("lists.collaborators.revoke")}
+                          </Button>
+                        </div>
                       ) : (
                         <div className="flex items-center gap-2">
                           <Select
diff --git a/apps/web/components/dashboard/lists/PendingInvitationsCard.tsx b/apps/web/components/dashboard/lists/PendingInvitationsCard.tsx
new file mode 100644
index 00000000..c453a91f
--- /dev/null
+++ b/apps/web/components/dashboard/lists/PendingInvitationsCard.tsx
@@ -0,0 +1,158 @@
+"use client";
+
+import { Button } from "@/components/ui/button";
+import {
+  Card,
+  CardContent,
+  CardDescription,
+  CardHeader,
+  CardTitle,
+} from "@/components/ui/card";
+import { toast } from "@/components/ui/use-toast";
+import { useTranslation } from "@/lib/i18n/client";
+import { api } from "@/lib/trpc";
+import { Check, Loader2, Mail, X } from "lucide-react";
+
+interface Invitation {
+  id: string;
+  role: string;
+  list: {
+    name: string;
+    icon?: string;
+    description?: string | null;
+    owner?: {
+      name?: string;
+    } | null;
+  };
+}
+
+function InvitationRow({ invitation }: { invitation: Invitation }) {
+  const { t } = useTranslation();
+  const utils = api.useUtils();
+
+  const acceptInvitation = api.lists.acceptInvitation.useMutation({
+    onSuccess: async () => {
+      toast({
+        description: t("lists.invitations.accepted"),
+      });
+      await Promise.all([
+        utils.lists.getPendingInvitations.invalidate(),
+        utils.lists.list.invalidate(),
+      ]);
+    },
+    onError: (error) => {
+      toast({
+        variant: "destructive",
+        description: error.message || t("lists.invitations.failed_to_accept"),
+      });
+    },
+  });
+
+  const declineInvitation = api.lists.declineInvitation.useMutation({
+    onSuccess: async () => {
+      toast({
+        description: t("lists.invitations.declined"),
+      });
+      await utils.lists.getPendingInvitations.invalidate();
+    },
+    onError: (error) => {
+      toast({
+        variant: "destructive",
+        description: error.message || t("lists.invitations.failed_to_decline"),
+      });
+    },
+  });
+
+  return (
+    <div className="flex items-center justify-between rounded-lg border p-4">
+      <div className="flex-1">
+        <div className="flex items-center gap-2">
+          <span className="font-medium">{invitation.list.name}</span>
+          <span className="text-xs text-muted-foreground">
+            {invitation.list.icon}
+          </span>
+        </div>
+        {invitation.list.description && (
+          <div className="mt-1 text-sm text-muted-foreground">
+            {invitation.list.description}
+          </div>
+        )}
+        <div className="mt-2 text-sm text-muted-foreground">
+          {t("lists.invitations.invited_by")}{" "}
+          <span className="font-medium">
+            {invitation.list.owner?.name || "Unknown"}
+          </span>
+          {" • "}
+          <span className="capitalize">{invitation.role}</span>
+        </div>
+      </div>
+      <div className="flex items-center gap-2">
+        <Button
+          size="sm"
+          variant="outline"
+          onClick={() =>
+            declineInvitation.mutate({ invitationId: invitation.id })
+          }
+          disabled={declineInvitation.isPending || acceptInvitation.isPending}
+        >
+          {declineInvitation.isPending ? (
+            <Loader2 className="h-4 w-4 animate-spin" />
+          ) : (
+            <>
+              <X className="mr-1 h-4 w-4" />
+              {t("lists.invitations.decline")}
+            </>
+          )}
+        </Button>
+        <Button
+          size="sm"
+          onClick={() =>
+            acceptInvitation.mutate({ invitationId: invitation.id })
+          }
+          disabled={acceptInvitation.isPending || declineInvitation.isPending}
+        >
+          {acceptInvitation.isPending ? (
+            <Loader2 className="h-4 w-4 animate-spin" />
+          ) : (
+            <>
+              <Check className="mr-1 h-4 w-4" />
+              {t("lists.invitations.accept")}
+            </>
+          )}
+        </Button>
+      </div>
+    </div>
+  );
+}
+
+export function PendingInvitationsCard() {
+  const { t } = useTranslation();
+
+  const { data: invitations, isLoading } =
+    api.lists.getPendingInvitations.useQuery();
+
+  if (isLoading) {
+    return null;
+  }
+
+  if (!invitations || invitations.length === 0) {
+    return null;
+  }
+
+  return (
+    <Card>
+      <CardHeader>
+        <CardTitle className="flex items-center gap-2">
+          <Mail className="h-5 w-5" />
+          {t("lists.invitations.pending")} ({invitations.length})
+        </CardTitle>
+        <CardDescription>{t("lists.invitations.description")}</CardDescription>
+      </CardHeader>
+      <CardContent className="space-y-3">
+        {invitations.map((invitation) => (
+          <InvitationRow key={invitation.id} invitation={invitation} />
+        ))}
+      </CardContent>
+    </Card>
+  );
+}
diff --git a/apps/web/lib/i18n/locales/en/translation.json b/apps/web/lib/i18n/locales/en/translation.json
index abc0d51a..87b46f6a 100644
--- a/apps/web/lib/i18n/locales/en/translation.json
+++ b/apps/web/lib/i18n/locales/en/translation.json
@@ -512,14 +512,20 @@
       "enter_email": "Enter email address",
       "please_enter_email": "Please enter an email address",
       "added_successfully": "Collaborator added successfully",
+      "invitation_sent": "Invitation sent successfully",
       "failed_to_add": "Failed to add collaborator",
       "removed": "Collaborator removed",
       "failed_to_remove": "Failed to remove collaborator",
       "role_updated": "Role updated",
       "failed_to_update_role": "Failed to update role",
+      "invitation_revoked": "Invitation revoked",
+      "failed_to_revoke": "Failed to revoke invitation",
       "viewer": "Viewer",
       "editor": "Editor",
       "owner": "Owner",
+      "pending": "Pending",
+      "revoke": "Revoke",
+      "declined": "Declined",
       "viewer_description": "Can view bookmarks in the list",
       "editor_description": "Can add and remove bookmarks",
       "no_collaborators": "No collaborators yet. Add someone to start collaborating!",
@@ -527,6 +533,17 @@
       "people_with_access": "People who have access to this list",
       "add_or_remove": "Add or remove people who can access this list"
     },
+    "invitations": {
+      "pending": "Pending Invitations",
+      "description": "Review and respond to list collaboration invitations",
+      "invited_by": "Invited by",
+      "accept": "Accept",
+      "decline": "Decline",
+      "accepted": "Invitation accepted",
+      "declined": "Invitation declined",
+      "failed_to_accept": "Failed to accept invitation",
+      "failed_to_decline": "Failed to decline invitation"
+    },
     "leave_list": {
       "title": "Leave List",
       "confirm_message": "Are you sure you want to leave {{icon}} {{name}}?",
-- 
cgit v1.2.3-70-g09d2