From 4ba3e8047a5b1f160169617187436c09e91662ec Mon Sep 17 00:00:00 2001 From: Mohamed Bassem Date: Sun, 13 Jul 2025 10:33:47 +0000 Subject: fix: Fix the types of the bookmark types in the db query --- apps/workers/workers/assetPreprocessingWorker.ts | 10 ++++++++++ apps/workers/workers/inference/tagging.ts | 12 +++++++++++- 2 files changed, 21 insertions(+), 1 deletion(-) (limited to 'apps') diff --git a/apps/workers/workers/assetPreprocessingWorker.ts b/apps/workers/workers/assetPreprocessingWorker.ts index c3ecd1e0..f36908cc 100644 --- a/apps/workers/workers/assetPreprocessingWorker.ts +++ b/apps/workers/workers/assetPreprocessingWorker.ts @@ -189,6 +189,11 @@ async function extractAndSaveImageText( bookmark: NonNullable>>, isFixMode: boolean, ): Promise { + if (!bookmark.asset) { + throw new Error( + `[assetPreprocessing][${jobId}] Bookmark ${bookmark.id} has no asset attached`, + ); + } { const alreadyHasText = !!bookmark.asset.content; if (alreadyHasText && isFixMode) { @@ -232,6 +237,11 @@ async function extractAndSavePDFText( bookmark: NonNullable>>, isFixMode: boolean, ): Promise { + if (!bookmark.asset) { + throw new Error( + `[assetPreprocessing][${jobId}] Bookmark ${bookmark.id} has no asset attached`, + ); + } { const alreadyHasText = !!bookmark.asset.content; if (alreadyHasText && isFixMode) { diff --git a/apps/workers/workers/inference/tagging.ts b/apps/workers/workers/inference/tagging.ts index 3c7b5adb..47419a1f 100644 --- a/apps/workers/workers/inference/tagging.ts +++ b/apps/workers/workers/inference/tagging.ts @@ -118,6 +118,11 @@ async function inferTagsFromImage( inferenceClient: InferenceClient, abortSignal: AbortSignal, ) { + if (!bookmark.asset) { + throw new Error( + `[inference][${jobId}] Bookmark ${bookmark.id} has no asset attached`, + ); + } const { asset, metadata } = await readAsset({ userId: bookmark.userId, assetId: bookmark.asset.assetId, @@ -199,11 +204,16 @@ function containsTagsPlaceholder(prompts: { text: string }[]): boolean { } async function inferTagsFromPDF( - _jobId: string, + jobId: string, bookmark: NonNullable>>, inferenceClient: InferenceClient, abortSignal: AbortSignal, ) { + if (!bookmark.asset) { + throw new Error( + `[inference][${jobId}] Bookmark ${bookmark.id} has no asset attached`, + ); + } const prompt = buildTextPrompt( serverConfig.inference.inferredTagLang, await fetchCustomPrompts(bookmark.userId, "text"), -- cgit v1.2.3-70-g09d2