From 9fe09bfa9021c8d85d2d9aef591936101cab19f6 Mon Sep 17 00:00:00 2001
From: Mohamed Bassem <me@mbassem.com>
Date: Sun, 21 Sep 2025 16:27:21 +0000
Subject: fix: optimize memory usage of tag listing

---
 packages/trpc/routers/tags.test.ts | 74 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 74 insertions(+)

(limited to 'packages/trpc/routers')

diff --git a/packages/trpc/routers/tags.test.ts b/packages/trpc/routers/tags.test.ts
index a4d690ee..4004cc2c 100644
--- a/packages/trpc/routers/tags.test.ts
+++ b/packages/trpc/routers/tags.test.ts
@@ -20,6 +20,42 @@ describe("Tags Routes", () => {
     expect(res.numBookmarks).toBeGreaterThanOrEqual(0);
   });
 
+  test<CustomTestContext>("get tag returns bookmark stats", async ({
+    apiCallers,
+  }) => {
+    const tagsApi = apiCallers[0].tags;
+    const bookmarksApi = apiCallers[0].bookmarks;
+
+    const firstBookmark = await bookmarksApi.createBookmark({
+      url: "https://example.com/first",
+      type: BookmarkTypes.LINK,
+    });
+    const secondBookmark = await bookmarksApi.createBookmark({
+      url: "https://example.com/second",
+      type: BookmarkTypes.LINK,
+    });
+
+    const firstAttachment = await bookmarksApi.updateTags({
+      bookmarkId: firstBookmark.id,
+      attach: [{ tagName: "stats-tag" }],
+      detach: [],
+    });
+
+    const tagId = firstAttachment.attached[0];
+
+    await bookmarksApi.updateTags({
+      bookmarkId: secondBookmark.id,
+      attach: [{ tagId }],
+      detach: [],
+    });
+
+    const stats = await tagsApi.get({ tagId });
+
+    expect(stats.numBookmarks).toBe(2);
+    expect(stats.numBookmarksByAttachedType.human).toBe(2);
+    expect(stats.numBookmarksByAttachedType.ai).toBe(0);
+  });
+
   test<CustomTestContext>("get tag - not found", async ({ apiCallers }) => {
     const api = apiCallers[0].tags;
     await expect(() => api.get({ tagId: "nonExistentId" })).rejects.toThrow(
@@ -135,6 +171,44 @@ describe("Tags Routes", () => {
     expect(res.tags.some((tag) => tag.name === "tag2")).toBeTruthy();
   });
 
+  test<CustomTestContext>("list tags includes bookmark stats", async ({
+    apiCallers,
+  }) => {
+    const tagsApi = apiCallers[0].tags;
+    const bookmarksApi = apiCallers[0].bookmarks;
+
+    const firstBookmark = await bookmarksApi.createBookmark({
+      url: "https://example.com/list-first",
+      type: BookmarkTypes.LINK,
+    });
+    const secondBookmark = await bookmarksApi.createBookmark({
+      url: "https://example.com/list-second",
+      type: BookmarkTypes.LINK,
+    });
+
+    const firstAttachment = await bookmarksApi.updateTags({
+      bookmarkId: firstBookmark.id,
+      attach: [{ tagName: "list-stats-tag" }],
+      detach: [],
+    });
+
+    const tagId = firstAttachment.attached[0];
+
+    await bookmarksApi.updateTags({
+      bookmarkId: secondBookmark.id,
+      attach: [{ tagId }],
+      detach: [],
+    });
+
+    const list = await tagsApi.list();
+    const tagStats = list.tags.find((tag) => tag.id === tagId);
+
+    expect(tagStats).toBeDefined();
+    expect(tagStats!.numBookmarks).toBe(2);
+    expect(tagStats!.numBookmarksByAttachedType.human).toBe(2);
+    expect(tagStats!.numBookmarksByAttachedType.ai).toBe(0);
+  });
+
   test<CustomTestContext>("list tags - privacy", async ({ apiCallers }) => {
     const apiUser1 = apiCallers[0].tags;
     await apiUser1.create({ name: "user1Tag" });
-- 
cgit v1.2.3-70-g09d2