1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
|
import { beforeEach, describe, expect, test } from "vitest";
import { z } from "zod";
import {
bookmarkLinks,
bookmarks,
bookmarkTexts,
importStagingBookmarks,
} from "@karakeep/db/schema";
import { BookmarkTypes } from "@karakeep/shared/types/bookmarks";
import {
zCreateImportSessionRequestSchema,
zDeleteImportSessionRequestSchema,
zGetImportSessionStatsRequestSchema,
} from "@karakeep/shared/types/importSessions";
import { zNewBookmarkListSchema } from "@karakeep/shared/types/lists";
import type { APICallerType, CustomTestContext } from "../testUtils";
import { defaultBeforeEach } from "../testUtils";
beforeEach<CustomTestContext>(defaultBeforeEach(true));
describe("ImportSessions Routes", () => {
async function createTestList(api: APICallerType) {
const newListInput: z.infer<typeof zNewBookmarkListSchema> = {
name: "Test Import List",
description: "A test list for imports",
icon: "📋",
type: "manual",
};
const createdList = await api.lists.create(newListInput);
return createdList.id;
}
test<CustomTestContext>("create import session", async ({ apiCallers }) => {
const api = apiCallers[0].importSessions;
const listId = await createTestList(apiCallers[0]);
const newSessionInput: z.infer<typeof zCreateImportSessionRequestSchema> = {
name: "Test Import Session",
rootListId: listId,
};
const createdSession = await api.createImportSession(newSessionInput);
expect(createdSession).toMatchObject({
id: expect.any(String),
});
// Verify session appears in list
const sessions = await api.listImportSessions({});
const sessionFromList = sessions.sessions.find(
(s) => s.id === createdSession.id,
);
expect(sessionFromList).toBeDefined();
expect(sessionFromList?.name).toEqual(newSessionInput.name);
expect(sessionFromList?.rootListId).toEqual(listId);
});
test<CustomTestContext>("create import session without rootListId", async ({
apiCallers,
}) => {
const api = apiCallers[0].importSessions;
const newSessionInput: z.infer<typeof zCreateImportSessionRequestSchema> = {
name: "Test Import Session",
};
const createdSession = await api.createImportSession(newSessionInput);
expect(createdSession).toMatchObject({
id: expect.any(String),
});
// Verify session appears in list
const sessions = await api.listImportSessions({});
const sessionFromList = sessions.sessions.find(
(s) => s.id === createdSession.id,
);
expect(sessionFromList?.rootListId).toBeNull();
});
test<CustomTestContext>("get import session stats", async ({
apiCallers,
}) => {
const api = apiCallers[0];
const session = await api.importSessions.createImportSession({
name: "Test Import Session",
});
// Stage bookmarks using the staging flow
await api.importSessions.stageImportedBookmarks({
importSessionId: session.id,
bookmarks: [
{ type: "text", content: "Test bookmark 1", tags: [], listIds: [] },
{ type: "text", content: "Test bookmark 2", tags: [], listIds: [] },
],
});
const statsInput: z.infer<typeof zGetImportSessionStatsRequestSchema> = {
importSessionId: session.id,
};
const stats = await api.importSessions.getImportSessionStats(statsInput);
expect(stats).toMatchObject({
id: session.id,
name: "Test Import Session",
status: "staging",
totalBookmarks: 2,
pendingBookmarks: 2,
completedBookmarks: 0,
failedBookmarks: 0,
processingBookmarks: 0,
});
});
test<CustomTestContext>("stats reflect crawl and tagging status for completed staging bookmarks", async ({
apiCallers,
db,
}) => {
const api = apiCallers[0];
const session = await api.importSessions.createImportSession({
name: "Test Import Session",
});
// Create bookmarks with different crawl/tag statuses
const user = (await db.query.users.findFirst())!;
// 1. Link bookmark: crawl success, tag success -> completed
const [completedLinkBookmark] = await db
.insert(bookmarks)
.values({
userId: user.id,
type: BookmarkTypes.LINK,
taggingStatus: "success",
})
.returning();
await db.insert(bookmarkLinks).values({
id: completedLinkBookmark.id,
url: "https://example.com/1",
crawlStatus: "success",
});
// 2. Link bookmark: crawl pending, tag success -> processing
const [crawlPendingBookmark] = await db
.insert(bookmarks)
.values({
userId: user.id,
type: BookmarkTypes.LINK,
taggingStatus: "success",
})
.returning();
await db.insert(bookmarkLinks).values({
id: crawlPendingBookmark.id,
url: "https://example.com/2",
crawlStatus: "pending",
});
// 3. Text bookmark: tag pending -> processing
const [tagPendingBookmark] = await db
.insert(bookmarks)
.values({
userId: user.id,
type: BookmarkTypes.TEXT,
taggingStatus: "pending",
})
.returning();
await db.insert(bookmarkTexts).values({
id: tagPendingBookmark.id,
text: "Test text",
});
// 4. Link bookmark: crawl failure -> failed
const [crawlFailedBookmark] = await db
.insert(bookmarks)
.values({
userId: user.id,
type: BookmarkTypes.LINK,
taggingStatus: "success",
})
.returning();
await db.insert(bookmarkLinks).values({
id: crawlFailedBookmark.id,
url: "https://example.com/3",
crawlStatus: "failure",
});
// 5. Text bookmark: tag failure -> failed
const [tagFailedBookmark] = await db
.insert(bookmarks)
.values({
userId: user.id,
type: BookmarkTypes.TEXT,
taggingStatus: "failure",
})
.returning();
await db.insert(bookmarkTexts).values({
id: tagFailedBookmark.id,
text: "Test text 2",
});
// 6. Text bookmark: tag success (no crawl needed) -> completed
const [completedTextBookmark] = await db
.insert(bookmarks)
.values({
userId: user.id,
type: BookmarkTypes.TEXT,
taggingStatus: "success",
})
.returning();
await db.insert(bookmarkTexts).values({
id: completedTextBookmark.id,
text: "Test text 3",
});
// Create staging bookmarks in different states
// Note: With the new import worker design, items stay in "processing" until
// crawl/tag is done. Only then do they move to "completed".
await db.insert(importStagingBookmarks).values([
// Staging pending -> pendingBookmarks
{
importSessionId: session.id,
type: "text",
content: "pending staging",
status: "pending",
},
// Staging processing (no bookmark yet) -> processingBookmarks
{
importSessionId: session.id,
type: "text",
content: "processing staging",
status: "processing",
},
// Staging failed -> failedBookmarks
{
importSessionId: session.id,
type: "text",
content: "failed staging",
status: "failed",
},
// Staging completed + crawl/tag success -> completedBookmarks
{
importSessionId: session.id,
type: "link",
url: "https://example.com/1",
status: "completed",
resultBookmarkId: completedLinkBookmark.id,
},
// Staging processing + crawl pending -> processingBookmarks (waiting for crawl)
{
importSessionId: session.id,
type: "link",
url: "https://example.com/2",
status: "processing",
resultBookmarkId: crawlPendingBookmark.id,
},
// Staging processing + tag pending -> processingBookmarks (waiting for tag)
{
importSessionId: session.id,
type: "text",
content: "tag pending",
status: "processing",
resultBookmarkId: tagPendingBookmark.id,
},
// Staging completed + crawl failure -> completedBookmarks (failure is terminal)
{
importSessionId: session.id,
type: "link",
url: "https://example.com/3",
status: "completed",
resultBookmarkId: crawlFailedBookmark.id,
},
// Staging completed + tag failure -> completedBookmarks (failure is terminal)
{
importSessionId: session.id,
type: "text",
content: "tag failed",
status: "completed",
resultBookmarkId: tagFailedBookmark.id,
},
// Staging completed + tag success (text, no crawl) -> completedBookmarks
{
importSessionId: session.id,
type: "text",
content: "completed text",
status: "completed",
resultBookmarkId: completedTextBookmark.id,
},
]);
const stats = await api.importSessions.getImportSessionStats({
importSessionId: session.id,
});
expect(stats).toMatchObject({
totalBookmarks: 9,
pendingBookmarks: 1, // staging pending
processingBookmarks: 3, // staging processing (no bookmark) + crawl pending + tag pending
completedBookmarks: 4, // link success + text success + crawl failure + tag failure
failedBookmarks: 1, // staging failed
});
});
test<CustomTestContext>("list import sessions returns all sessions", async ({
apiCallers,
}) => {
const api = apiCallers[0].importSessions;
const sessionNames = ["Session 1", "Session 2", "Session 3"];
for (const name of sessionNames) {
await api.createImportSession({ name });
}
const result = await api.listImportSessions({});
expect(result.sessions).toHaveLength(3);
expect(result.sessions.map((session) => session.name)).toEqual(
sessionNames,
);
expect(
result.sessions.every((session) => session.totalBookmarks === 0),
).toBe(true);
});
test<CustomTestContext>("delete import session", async ({ apiCallers }) => {
const api = apiCallers[0].importSessions;
const session = await api.createImportSession({
name: "Session to Delete",
});
const deleteInput: z.infer<typeof zDeleteImportSessionRequestSchema> = {
importSessionId: session.id,
};
const result = await api.deleteImportSession(deleteInput);
expect(result.success).toBe(true);
// Verify session no longer exists
await expect(
api.getImportSessionStats({
importSessionId: session.id,
}),
).rejects.toThrow("Import session not found");
});
test<CustomTestContext>("cannot access other user's session", async ({
apiCallers,
}) => {
const api1 = apiCallers[0].importSessions;
const api2 = apiCallers[1].importSessions;
// User 1 creates a session
const session = await api1.createImportSession({
name: "User 1 Session",
});
// User 2 tries to access it
await expect(
api2.getImportSessionStats({
importSessionId: session.id,
}),
).rejects.toThrow("Import session not found");
await expect(
api2.deleteImportSession({
importSessionId: session.id,
}),
).rejects.toThrow("Import session not found");
});
test<CustomTestContext>("cannot stage other user's session", async ({
apiCallers,
}) => {
const api1 = apiCallers[0];
const api2 = apiCallers[1];
// User 1 creates session and bookmark
const session = await api1.importSessions.createImportSession({
name: "User 1 Session",
});
// User 1 tries to attach User 2's bookmark
await expect(
api2.importSessions.stageImportedBookmarks({
importSessionId: session.id,
bookmarks: [
{
type: "text",
content: "Test bookmark",
tags: [],
listIds: [],
},
],
}),
).rejects.toThrow("Import session not found");
});
});
|